congsh/gamegroup
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore: 代码风格统一和项目文档添加

Browse Source 
主要变更：

1. 代码风格统一
   - 统一使用双引号替代单引号
   - 保持项目代码风格一致性
   - 涵盖所有模块、配置、实体和服务文件

2. 项目文档
   - 新增 SECURITY_FIXES_SUMMARY.md - 安全修复总结文档
   - 新增 项目问题评估报告.md - 项目问题评估文档

3. 包含修改的文件类别
   - 配置文件：app, database, jwt, redis, cache, performance
   - 实体文件：所有 TypeORM 实体
   - 模块文件：所有业务模块
   - 公共模块：guards, decorators, interceptors, filters, utils
   - 测试文件：单元测试和 E2E 测试

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This commit is contained in:
UGREEN USER
2026-01-28 13:03:28 +08:00
parent d73a6e28b3
commit 575a29ac8f
103 changed files with 3651 additions and 2710 deletions
Download Patch File Download Diff File Expand all files Collapse all files

200
src/modules/ledgers/ledgers.service.spec.ts
View File

@@ -1,50 +1,50 @@
import { Test, TestingModule } from '@nestjs/testing';
import { getRepositoryToken } from '@nestjs/typeorm';
import { Test, TestingModule } from "@nestjs/testing";
import { getRepositoryToken } from "@nestjs/typeorm";
import {
NotFoundException,
BadRequestException,
ForbiddenException,
} from '@nestjs/common';
import { LedgersService } from './ledgers.service';
import { Ledger } from '../../entities/ledger.entity';
import { Group } from '../../entities/group.entity';
import { GroupMember } from '../../entities/group-member.entity';
} from "@nestjs/common";
import { LedgersService } from "./ledgers.service";
import { Ledger } from "../../entities/ledger.entity";
import { Group } from "../../entities/group.entity";
import { GroupMember } from "../../entities/group-member.entity";
enum LedgerType {
INCOME = 'income',
EXPENSE = 'expense',
INCOME = "income",
EXPENSE = "expense",
}
describe('LedgersService', () => {
describe("LedgersService", () => {
let service: LedgersService;
let mockLedgerRepository: any;
let mockGroupRepository: any;
let mockGroupMemberRepository: any;
const mockUser = { id: 'user-1', username: 'testuser' };
const mockGroup = {
id: 'group-1',
name: '测试小组',
const mockUser = { id: "user-1", username: "testuser" };
const mockGroup = {
id: "group-1",
name: "测试小组",
isActive: true,
parentId: null,
};
const mockMembership = {
id: 'member-1',
userId: 'user-1',
groupId: 'group-1',
role: 'member',
id: "member-1",
userId: "user-1",
groupId: "group-1",
role: "member",
isActive: true,
};
const mockLedger = {
id: 'ledger-1',
groupId: 'group-1',
creatorId: 'user-1',
id: "ledger-1",
groupId: "group-1",
creatorId: "user-1",
type: LedgerType.INCOME,
amount: 100,
category: '聚餐费用',
description: '周末聚餐',
createdAt: new Date('2024-01-20T10:00:00Z'),
category: "聚餐费用",
description: "周末聚餐",
createdAt: new Date("2024-01-20T10:00:00Z"),
updatedAt: new Date(),
};
@@ -87,8 +87,8 @@ describe('LedgersService', () => {
service = module.get<LedgersService>(LedgersService);
});
describe('create', () => {
it('应该成功创建账目', async () => {
describe("create", () => {
it("应该成功创建账目", async () => {
mockGroupRepository.findOne.mockResolvedValue(mockGroup);
mockGroupMemberRepository.findOne.mockResolvedValue(mockMembership);
mockLedgerRepository.create.mockReturnValue(mockLedger);
@@ -99,66 +99,66 @@ describe('LedgersService', () => {
creator: mockUser,
});
const result = await service.create('user-1', {
groupId: 'group-1',
const result = await service.create("user-1", {
groupId: "group-1",
type: LedgerType.INCOME,
amount: 100,
category: '聚餐费用',
description: '周末聚餐',
category: "聚餐费用",
description: "周末聚餐",
});
expect(result).toHaveProperty('id');
expect(result).toHaveProperty("id");
expect(result.amount).toBe(100);
expect(mockLedgerRepository.save).toHaveBeenCalled();
});
it('应该在小组不存在时抛出异常', async () => {
it("应该在小组不存在时抛出异常", async () => {
mockGroupRepository.findOne.mockResolvedValue(null);
await expect(
service.create('user-1', {
groupId: 'group-1',
service.create("user-1", {
groupId: "group-1",
type: LedgerType.INCOME,
amount: 100,
category: '聚餐费用',
description: '测试',
category: "聚餐费用",
description: "测试",
}),
).rejects.toThrow(NotFoundException);
});
it('应该在用户不在小组中时抛出异常', async () => {
it("应该在用户不在小组中时抛出异常", async () => {
mockGroupRepository.findOne.mockResolvedValue(mockGroup);
mockGroupMemberRepository.findOne.mockResolvedValue(null);
await expect(
service.create('user-1', {
groupId: 'group-1',
service.create("user-1", {
groupId: "group-1",
type: LedgerType.INCOME,
amount: 100,
category: '聚餐费用',
description: '测试',
category: "聚餐费用",
description: "测试",
}),
).rejects.toThrow(ForbiddenException);
});
it('应该在金额无效时抛出异常', async () => {
it("应该在金额无效时抛出异常", async () => {
mockGroupRepository.findOne.mockResolvedValue(mockGroup);
mockGroupMemberRepository.findOne.mockResolvedValue(mockMembership);
await expect(
service.create('user-1', {
groupId: 'group-1',
service.create("user-1", {
groupId: "group-1",
type: LedgerType.INCOME,
amount: -100,
category: '聚餐费用',
description: '测试',
category: "聚餐费用",
description: "测试",
}),
).rejects.toThrow(BadRequestException);
});
});
describe('findAll', () => {
it('应该成功获取账目列表', async () => {
describe("findAll", () => {
it("应该成功获取账目列表", async () => {
const mockQueryBuilder = {
leftJoinAndSelect: jest.fn().mockReturnThis(),
where: jest.fn().mockReturnThis(),
@@ -172,18 +172,18 @@ describe('LedgersService', () => {
mockLedgerRepository.createQueryBuilder.mockReturnValue(mockQueryBuilder);
mockGroupMemberRepository.findOne.mockResolvedValue(mockMembership);
const result = await service.findAll('user-1', {
groupId: 'group-1',
const result = await service.findAll("user-1", {
groupId: "group-1",
page: 1,
limit: 10,
});
expect(result).toHaveProperty('items');
expect(result).toHaveProperty('total');
expect(result).toHaveProperty("items");
expect(result).toHaveProperty("total");
expect(result.items).toHaveLength(1);
});
it('应该支持按类型筛选', async () => {
it("应该支持按类型筛选", async () => {
const mockQueryBuilder = {
leftJoinAndSelect: jest.fn().mockReturnThis(),
where: jest.fn().mockReturnThis(),
@@ -197,8 +197,8 @@ describe('LedgersService', () => {
mockLedgerRepository.createQueryBuilder.mockReturnValue(mockQueryBuilder);
mockGroupMemberRepository.findOne.mockResolvedValue(mockMembership);
const result = await service.findAll('user-1', {
groupId: 'group-1',
const result = await service.findAll("user-1", {
groupId: "group-1",
type: LedgerType.INCOME,
page: 1,
limit: 10,
@@ -209,31 +209,31 @@ describe('LedgersService', () => {
});
});
describe('findOne', () => {
it('应该成功获取账目详情', async () => {
describe("findOne", () => {
it("应该成功获取账目详情", async () => {
mockLedgerRepository.findOne.mockResolvedValue({
...mockLedger,
group: mockGroup,
creator: mockUser,
});
const result = await service.findOne('ledger-1');
const result = await service.findOne("ledger-1");
expect(result).toHaveProperty('id');
expect(result.id).toBe('ledger-1');
expect(result).toHaveProperty("id");
expect(result.id).toBe("ledger-1");
});
it('应该在账目不存在时抛出异常', async () => {
it("应该在账目不存在时抛出异常", async () => {
mockLedgerRepository.findOne.mockResolvedValue(null);
await expect(service.findOne('ledger-1')).rejects.toThrow(
await expect(service.findOne("ledger-1")).rejects.toThrow(
NotFoundException,
);
});
});
describe('update', () => {
it('应该成功更新账目', async () => {
describe("update", () => {
it("应该成功更新账目", async () => {
mockLedgerRepository.findOne
.mockResolvedValueOnce(mockLedger)
.mockResolvedValueOnce({
@@ -244,70 +244,70 @@ describe('LedgersService', () => {
});
mockGroupMemberRepository.findOne.mockResolvedValue({
...mockMembership,
role: 'admin',
role: "admin",
});
mockLedgerRepository.save.mockResolvedValue({
...mockLedger,
amount: 200,
});
const result = await service.update('user-1', 'ledger-1', {
const result = await service.update("user-1", "ledger-1", {
amount: 200,
});
expect(result.amount).toBe(200);
});
it('应该在账目不存在时抛出异常', async () => {
it("应该在账目不存在时抛出异常", async () => {
mockLedgerRepository.findOne.mockResolvedValue(null);
await expect(
service.update('user-1', 'ledger-1', { amount: 200 }),
service.update("user-1", "ledger-1", { amount: 200 }),
).rejects.toThrow(NotFoundException);
});
it('应该在无权限时抛出异常', async () => {
it("应该在无权限时抛出异常", async () => {
mockLedgerRepository.findOne.mockResolvedValue(mockLedger);
mockGroupMemberRepository.findOne.mockResolvedValue({
...mockMembership,
role: 'member',
role: "member",
});
await expect(
service.update('user-2', 'ledger-1', { amount: 200 }),
service.update("user-2", "ledger-1", { amount: 200 }),
).rejects.toThrow(ForbiddenException);
});
});
describe('remove', () => {
it('应该成功删除账目', async () => {
describe("remove", () => {
it("应该成功删除账目", async () => {
mockLedgerRepository.findOne.mockResolvedValue(mockLedger);
mockGroupMemberRepository.findOne.mockResolvedValue({
...mockMembership,
role: 'admin',
role: "admin",
});
mockLedgerRepository.remove.mockResolvedValue(mockLedger);
const result = await service.remove('user-1', 'ledger-1');
const result = await service.remove("user-1", "ledger-1");
expect(result).toHaveProperty('message');
expect(result).toHaveProperty("message");
});
it('应该在无权限时抛出异常', async () => {
it("应该在无权限时抛出异常", async () => {
mockLedgerRepository.findOne.mockResolvedValue(mockLedger);
mockGroupMemberRepository.findOne.mockResolvedValue({
...mockMembership,
role: 'member',
role: "member",
});
await expect(
service.remove('user-2', 'ledger-1'),
).rejects.toThrow(ForbiddenException);
await expect(service.remove("user-2", "ledger-1")).rejects.toThrow(
ForbiddenException,
);
});
});
describe('getMonthlyStatistics', () => {
it('应该成功获取月度统计', async () => {
describe("getMonthlyStatistics", () => {
it("应该成功获取月度统计", async () => {
const mockQueryBuilder = {
where: jest.fn().mockReturnThis(),
andWhere: jest.fn().mockReturnThis(),
@@ -320,24 +320,24 @@ describe('LedgersService', () => {
mockLedgerRepository.createQueryBuilder.mockReturnValue(mockQueryBuilder);
mockGroupMemberRepository.findOne.mockResolvedValue(mockMembership);
const result = await service.getMonthlyStatistics('user-1', {
groupId: 'group-1',
const result = await service.getMonthlyStatistics("user-1", {
groupId: "group-1",
year: 2024,
month: 1,
});
expect(result).toHaveProperty('income');
expect(result).toHaveProperty('expense');
expect(result).toHaveProperty('balance');
expect(result).toHaveProperty('categories');
expect(result).toHaveProperty("income");
expect(result).toHaveProperty("expense");
expect(result).toHaveProperty("balance");
expect(result).toHaveProperty("categories");
});
it('应该在用户不在小组时抛出异常', async () => {
it("应该在用户不在小组时抛出异常", async () => {
mockGroupMemberRepository.findOne.mockResolvedValue(null);
await expect(
service.getMonthlyStatistics('user-1', {
groupId: 'group-1',
service.getMonthlyStatistics("user-1", {
groupId: "group-1",
year: 2024,
month: 1,
}),
@@ -345,9 +345,9 @@ describe('LedgersService', () => {
});
});
describe('getHierarchicalSummary', () => {
it('应该成功获取层级汇总', async () => {
const childGroup = { id: 'group-2', name: '子小组', parentId: 'group-1' };
describe("getHierarchicalSummary", () => {
it("应该成功获取层级汇总", async () => {
const childGroup = { id: "group-2", name: "子小组", parentId: "group-1" };
const mockQueryBuilder = {
where: jest.fn().mockReturnThis(),
getMany: jest.fn().mockResolvedValue([mockLedger]),
@@ -358,12 +358,12 @@ describe('LedgersService', () => {
mockGroupRepository.find.mockResolvedValue([childGroup]);
mockLedgerRepository.createQueryBuilder.mockReturnValue(mockQueryBuilder);
const result = await service.getHierarchicalSummary('user-1', 'group-1');
const result = await service.getHierarchicalSummary("user-1", "group-1");
expect(result).toHaveProperty('groupId');
expect(result).toHaveProperty('income');
expect(result).toHaveProperty('expense');
expect(result).toHaveProperty('balance');
expect(result).toHaveProperty("groupId");
expect(result).toHaveProperty("income");
expect(result).toHaveProperty("expense");
expect(result).toHaveProperty("balance");
});
});
});